Building review checklistsBuilding review checklists, ContinuedDevising checksOrganizing checklist itemsExample ChecklistsDesign and code review checklistsExample checklists, ContinuedEvaluation criteriaEvaluation criteriaPSP2 Design Review ScriptPurposeTo guide you in reviewing detailed designsEntry Criteria- Completed program design- Design Review checklist- Design standard- Defect Type standard- Time and Defect Recording logsGeneralWhere the design was previously verified, check that the analyses- covered all of the design- were updated for all design changes- are correct- are clear and completeStep Activities Description1 Preparation Examine the program and checklist and decide on a review strategy.2 Review - Follow the Design Review checklist.- Review the entire program for each checklist category; do not try to review for more than one category at a time!- Check off each item as you complete it.- Complete a separate checklist for each product or product segment reviewed.3 Fix Check - Check each defect fix for correctness.- Re-review all changes.- Record any fix defects as new defects and, where you know the defective defect number, enter it in the fix defect space.Exit Criteria- A fully reviewed detailed design- One or more Design Review checklists for every design reviewed- All identified defects fixed and all fixes checked- Completed Time and Defect Recording logsReview Checklists February 2005 1  2005 by Carnegie Mellon UniversityBuilding review checklistsOverviewWhen constructing review checklists, your objective is to identify and devise checks forthe specific defect types that you make.To build and improve your review checklists, you will need• a documented review process• detailed defect data on the errors that you make• data on the review processThese data can be derived from PSP defect logs and project plan summaries.The steps in constructing a review checklist are as follows:1. Analyze defect data to identify opportunities and priorities.2. Devise checks for the defects that you make.3. Organize checks to support the review process.Analyzing defect dataTo ensure that your reviews provide the most benefit, your checklists should focus on defects that• give you the most trouble• provide the most leverage A Pareto distribution will help you to establish priorities. Create distributions for• defect frequency by category• defect cost by categoryFigure 9.8, page 179, shows an example Pareto distribution. As you gather more data on defects, it may be necessary to create defect sub categories. An example sub-categorization is shown in Table 9.5, page 178.The interim and final reports contain other defect analyses that are useful in building review checklists.Defects injected and removed by phase- In what phase do I inject the most defects?- In what phase are they removed?- Could they be removed earlier?Defect types found by the compiler- What defect types will the compiler find?- How effective is the compiler at finding defects?- What defect types does the compiler missDefect fix time analysis - What does it cost to fix a defect?- What could be saved by removing defects earlier?Review Checklists February 2005 2  2005 by Carnegie Mellon UniversityDefect removal rates for reviews- How efficient are my review processes?- How do they compare?Review yield - How effective are my review processes?Continued on next pageReview Checklists February 2005 3  2005 by Carnegie Mellon UniversityBuilding review checklists, Con tinu e dDevising checksThe next step in building checklists is to devise checks for the highest priority defect types. Examine your defect logs to identify the specific defects that you make and devise checks to find them. Checks should be devised to specifically address the defects that you make. For example, if you often forget to include semicolons at the end of a statement, thendevise a checklist item for this defect.All statements end with a semicolonWhile too much detail can be overwhelming, reviews are generally more efficient when each checklist item has a small, easily tested scope that can be quickly and accurately checked.Organizing checklist itemsThe final step in building checklists is to organize your checklist items into categories.When selecting categories consider the following.• Merge similar items into one category.• Order categories to support your review strategy and process.The example design review and code review checklists illustrate one possible organization that you might use.The design review checklist organization is explained in the following table.Category Includes checks to ensure thatComplete The design is complete with respect to requirements, etc.Logic The program logic is correct.Special Cases Special and extreme cases are properly handled.Functional use Functional aspects and interfaces of the design are correct.Review Checklists February 2005 4  2005 by Carnegie Mellon UniversityNames Names, variables, parameters, objects, and so on are properly used and scoped.Standards The design conforms to design standards.Review Checklists February 2005 5  2005 by Carnegie Mellon UniversityExample ChecklistsDesign and code review checklistsThe following design and code review checklists can be used as a starting point for designing your own checklists.PSP2 Design Review ChecklistStudent DateProgram Program #Instructor LanguagePurposeTo guide you in conducting an effective design reviewGeneral- Review the entire program for each checklist category; do not attempt to reviewfor more than one category at a time!- As you complete each review step, check off that item in the box at the right.- Complete the checklist for one program or program unit before reviewing the next. Complete Verify that the design covers all of the applicable requirements.- All specified outputs are produced.- All needed inputs are furnished.- All required includes are stated.External LimitsWhere the design assumes or relies upon external limits, determine if behavior is correct at nominal values, at limits, and beyond limits.Logic- Verify that program sequencing is proper. Stacks, lists, and so on are in the proper order. Recursion unwinds properly.- Verify that all loops are properly initiated, incremented, and terminated.- Examine each conditional statement and verify all cases.Internal LimitsWhere the design assumes or relies upon internal limits, determine if behavior is correct at nominal values, at